Repository navigation
Consolidate PAFTOOLS into one task per sample - #26
Merged
Merged
Conversation
Fold split, align, coverage QC, call, sort, SnpEff, conversion and MNV correction into paftools_variants, and drop dead code along the path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same pass as #25, for PAFTOOLS. After BLAST, each sample now runs one
paftools_variantstask (modules/paftools/paftools.nf) in place of nine. Per-sample tasks go from 11 to 3:blastn,paftools_variants,mutation_watch. minimap2 gets an accession-only reference, so the CHROM rename before SnpEff, the referencesedinpost_process_vcfandbcftools sortare gone.Review
modules/paftools/paftools.nfandworkflows/paftools.nffirst. The rest is cleanup:filter_alignments.py: drop the dead groupby, the unused--min_cov/--min_id/--metric, and the min-max composite. Reference selection is unchanged; the composite crashed under pandas 3 when every hit had the same score.blastn's unused emits andsplit_fasta.py combine.post_process_vcfdrops from 16 to 2 CPUs.Output changes:
reference_idis the bare accession, notacc|subtype|segment.paftools_variantsrecord.*_blastn_filter.tsvlosescomposite.Verified on 6 GISAID samples (H1N1/H5N1/H9N2 SnpEff databases), running FASTA prep + PAFTOOLS through Nextflow on
mainand on this branch. All 48 final VCFs match apart from##SnpEffCmd/##bcftools_sortheader lines, and every other published file matches. Tasks went from 92 to 44 and summed PAFTOOLS task time from 370 s to 153 s. pytest has the same 5test_run_snpeff.pyfailures asmain. SHORT_READ was not smoke-tested.